Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move generate_precompile to Base so that it is bundled in downloads #30367

Closed
wants to merge 1 commit into from

Conversation

KristofferC
Copy link
Member

If one wants to rebuild the sysimg it is useful to have access to this script since it is what makes starting Julia, the REPL and Pkg fast. Not sure if this is the best way to make it bundle with the download.

cc @andreasnoack

@ararslan
Copy link
Member

Should this be backported to 1.0 as well?

@KristofferC
Copy link
Member Author

KristofferC commented Dec 12, 2018

Jameson says this is not needed and that one can add things incrementally to the existing sysimg.

That’s the very slow way to regenerate it though. The fast way to the same result is just to rerun the optimizer:
julia --output-o x-o.a -J lib/sys.so -O3 -g1 -e "nothing" -C nativ

@KristofferC KristofferC mentioned this pull request Dec 12, 2018
52 tasks
@andreasnoack
Copy link
Member

I believe this is still needed for my use case in MKL.jl.

@Petr-Hlavenka
Copy link
Contributor

Jameson says this is not needed and that one can add things incrementally to the existing sysimg.

That’s the very slow way to regenerate it though. The fast way to the same result is just to rerun the optimizer:
julia --output-o x-o.a -J lib/sys.so -O3 -g1 -e "nothing" -C nativ

Is this incremental build of sysimg used already by PackageCompiler? I had the impression that REPL responsiveness slowed down after I added Makie into the sysimg and blamed the missing REPL precompile. But I didn't spend time by proper benchmarking (I've decided to wait for Makie 1.0 and just reverted the old sysimg).

@KristofferC KristofferC mentioned this pull request Jan 5, 2019
15 tasks
@StefanKarpinski StefanKarpinski added backport 1.1 triage This should be discussed on a triage call and removed backport 1.1 labels Jan 31, 2019
@JeffBezanson
Copy link
Member

If we change this, it should be changed in the packaging script instead of moving it to base (it's not part of Base).

@JeffBezanson JeffBezanson removed backport 1.1 triage This should be discussed on a triage call labels Feb 14, 2019
@vtjnash vtjnash closed this Nov 8, 2021
@vtjnash
Copy link
Member

vtjnash commented Nov 8, 2021

PR seems old

@vtjnash vtjnash deleted the kc/move_precompile branch November 8, 2021 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants