Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stacktrace: prevent OOB-error in sysimage lookup #30369

Merged
merged 1 commit into from
Dec 17, 2018
Merged

stacktrace: prevent OOB-error in sysimage lookup #30369

merged 1 commit into from
Dec 17, 2018

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Dec 12, 2018

Previously, with a multi-versioned system image, there might be additional entries at the end of the clone list that do not correspond to an actual method (such as jlplt thunks).

Also some code cleanup for clarity.

fix #28648

@vtjnash vtjnash requested a review from yuyichao December 12, 2018 19:32
yuyichao
yuyichao approved these changes Dec 12, 2018
View reviewed changes
Copy link
Contributor

@yuyichao yuyichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The debug info part looks correct. Maybe just include that notes about plt thunk etc (i.e. the disagreement in the index for julia code and for multiversioning pass) in the comment?.

@vtjnash
stacktrace: prevent OOB-error in sysimage lookup
1e41d92 
Previously, with a multi-versioned system image, there might be additional entries at the end of the clone list
that do not correspond to an actual method (such as jlplt thunks).

Also some code cleanup for clarity.

fix #28648
@vtjnash vtjnash merged commit e51a707 into master Dec 17, 2018
@vtjnash vtjnash deleted the jn/28648 branch December 17, 2018 02:10
KristofferC pushed a commit that referenced this pull request Dec 20, 2018
@vtjnash @KristofferC
stacktrace: prevent OOB-error in sysimage lookup (#30369)
c045cbe 
Previously, with a multi-versioned system image, there might be additional entries at the end of the clone list
that do not correspond to an actual method (such as jlplt thunks).

Also some code cleanup for clarity.

fix #28648

(cherry picked from commit e51a707)
@KristofferC KristofferC mentioned this pull request Dec 20, 2018
Merged
52 tasks
KristofferC pushed a commit that referenced this pull request Dec 30, 2018
@vtjnash @KristofferC
stacktrace: prevent OOB-error in sysimage lookup (#30369)
0ab6919 
Previously, with a multi-versioned system image, there might be additional entries at the end of the clone list
that do not correspond to an actual method (such as jlplt thunks).

Also some code cleanup for clarity.

fix #28648

(cherry picked from commit e51a707)
@KristofferC KristofferC mentioned this pull request Dec 30, 2018
Closed
53 tasks
@andreasnoack andreasnoack mentioned this pull request Jan 15, 2019
Closed
@StefanKarpinski StefanKarpinski added triage This should be discussed on a triage call backport 1.0 and removed triage This should be discussed on a triage call labels Jan 31, 2019
@JeffBezanson JeffBezanson added bugfix This change fixes an existing bug and removed triage This should be discussed on a triage call triage backport pending 1.0 labels Jan 31, 2019
KristofferC pushed a commit that referenced this pull request Feb 4, 2019
@vtjnash @KristofferC
stacktrace: prevent OOB-error in sysimage lookup (#30369)
54c136d 
Previously, with a multi-versioned system image, there might be additional entries at the end of the clone list
that do not correspond to an actual method (such as jlplt thunks).

Also some code cleanup for clarity.

fix #28648

(cherry picked from commit e51a707)
@KristofferC KristofferC mentioned this pull request Feb 4, 2019
Merged
39 tasks
KristofferC pushed a commit that referenced this pull request Feb 11, 2019
@vtjnash @KristofferC
stacktrace: prevent OOB-error in sysimage lookup (#30369)
7ef571a 
Previously, with a multi-versioned system image, there might be additional entries at the end of the clone list
that do not correspond to an actual method (such as jlplt thunks).

Also some code cleanup for clarity.

fix #28648

(cherry picked from commit e51a707)
KristofferC pushed a commit that referenced this pull request Apr 20, 2019
@vtjnash @KristofferC
stacktrace: prevent OOB-error in sysimage lookup (#30369)
0073e42 
Previously, with a multi-versioned system image, there might be additional entries at the end of the clone list
that do not correspond to an actual method (such as jlplt thunks).

Also some code cleanup for clarity.

fix #28648

(cherry picked from commit e51a707)
KristofferC pushed a commit that referenced this pull request Feb 20, 2020
@vtjnash @KristofferC
stacktrace: prevent OOB-error in sysimage lookup (#30369)
05a7e48 
Previously, with a multi-versioned system image, there might be additional entries at the end of the clone list
that do not correspond to an actual method (such as jlplt thunks).

Also some code cleanup for clarity.

fix #28648

(cherry picked from commit e51a707)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuyichao yuyichao yuyichao approved these changes

Assignees
No one assigned
Labels
bugfix This change fixes an existing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Profiler segmentation fault
5 participants
@vtjnash @yuyichao @StefanKarpinski @JeffBezanson @KristofferC