-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
attempt to refine return type when it could be improved via PartialTuple #30385
Conversation
1199883
to
4e1fac8
Compare
4e1fac8
to
5fd036d
Compare
@nanosoldier |
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan |
Looks like some decent improvements across the board, a few regressions too. Here are the potential regressions that seem worth looking into:
I'll do some digging on these tomorrow or so when I get a chance. In the meantime would be great to get some review, especially since there are already merge conflicts cropping up. Would like to get this in ASAP pending investigation of the above regressions. |
5fd036d
to
f95d2e3
Compare
Huh, the sparse index benchmarks are pretty noisy on my local machine. I have to kick Same for the array comprehension benchmark; it's unfortunately a bit longer running, so I don't have time to get convergence in the minimum, but the medians seemed to converge around the 500 sample mark on my machine, with the result once again pointing to essentially no change with this PR. We should consider reconfiguring the time/sample budget on Nanosoldier for those benchmarks... The |
thanks to @vtjnash
fixes #30380