Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix maximum on generic orders #30441

Merged
merged 2 commits into from
Dec 20, 2018
Merged

fix maximum on generic orders #30441

merged 2 commits into from
Dec 20, 2018

Conversation

jw3126
Copy link
Contributor

@jw3126 jw3126 commented Dec 18, 2018 •
edited by ararslan
Loading

Closes #30436
See #30320

@ararslan
Copy link
Member

@nanosoldier runbenchmarks(ALL, vs=":master")

@ViralBShah ViralBShah mentioned this pull request Dec 18, 2018
Closed
@ararslan ararslan requested a review from mbauman December 18, 2018 23:44
@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

jw3126
jw3126 commented Dec 19, 2018
View reviewed changes
base/reduce.jl Outdated Show resolved Hide resolved
@jw3126
Copy link
Contributor Author

jw3126 commented Dec 19, 2018

This is still as fast:

julia> using BenchmarkTools; arr = randn(10^6); @benchmark maximum($arr)
[ Info: Precompiling BenchmarkTools [6e4b80f9-dd63-53aa-95a3-0cdb28fa8baf]
BenchmarkTools.Trial: 
  memory estimate:  0 bytes
  allocs estimate:  0
  --------------
  minimum time:     560.122 μs (0.00% GC)
  median time:      587.918 μs (0.00% GC)
  mean time:        593.810 μs (0.00% GC)
  maximum time:     1.197 ms (0.00% GC)
  --------------
  samples:          8328
  evals/sample:     1

@ViralBShah
Copy link
Member

Good to merge?

@jw3126
Copy link
Contributor Author

jw3126 commented Dec 19, 2018

I also think so.

@ViralBShah ViralBShah merged commit 744ead4 into JuliaLang:master Dec 20, 2018
@tkoolen tkoolen mentioned this pull request Dec 20, 2018
Closed
@StefanKarpinski StefanKarpinski added backport 1.1 triage This should be discussed on a triage call and removed backport 1.1 labels Jan 31, 2019
@Keno Keno removed the triage This should be discussed on a triage call label Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbauman mbauman mbauman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jw3126 @ararslan @nanosoldier @ViralBShah @mbauman @StefanKarpinski @Keno