Add Dates as a test dependency to SparseArrays. #30519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikekre
added
domain:arrays:sparse
ararslan
approved these changes
Dec 26, 2018
27 tasks
KristofferC
pushed a commit
that referenced
this pull request
Dec 27, 2018
(cherry picked from commit 573cf74)
staticfloat
pushed a commit
that referenced
this pull request
Dec 30, 2018
|
Do we need this on 1.0 also? |
|
Not unless #30228 is also backported. |
|
I just added the |
|
That can't be backport to 1.0, as it's labeled a minor change. |
|
It's also already been backported to 1.1.0 |
staticfloat
pushed a commit
that referenced
this pull request
Jan 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Dates as a test dependency to SparseArrays, missed in #30228.