make: fix build warnings and other dependency issues #30553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
added
building
|
Applicable to 1.0? |
vtjnash
force-pushed
the
jn/30377
branch
2 times, most recently
from
385f05a to
94bd64c
Compare
This avoids recursively running the same makefile, as we do for all others. fix #30377
This rule was unused, and wouldn't work for an out-of-tree build anyways. ref #27922
We don't actually provide libunwind in most cases (on linux, it's a static library; on windows, it's provided by dbghelp; on macos, it's provided by libosxunwind). fix #29163
|
...so I assume that's a no, this is not applicable to 1.0? |
|
Some might be back-portable, but since it's just make system improvements, they aren't critical |
StefanKarpinski
added
backport 1.1
triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.