refactor resolve-scopes pass #30656
Merged
refactor resolve-scopes pass #30656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
the
compiler:lowering
|
And it is a net deletion of code (at least as of now)! |
JeffBezanson
force-pushed
the
jb/resolvescopes
branch
2 times, most recently
from
241f9ee
to
f196d02
Compare
JeffBezanson
changed the title
JeffBezanson
force-pushed
the
jb/resolvescopes
branch
from
f196d02
to
5b8d23a
Compare
JeffBezanson
force-pushed
the
jb/resolvescopes
branch
from
5b8d23a
to
5dedbf9
Compare
|
Ok, PkgEval identified one problem with underscore handling 🎉 Now this should be ready to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a much-needed rewrite of
resolve-scopes. Many reasons have accumulated:The code for it has grown quite confusing and unmaintainable, making it hard to address these issues. Hopefully this PR makes it much easier to read and modify. It also removes a bunch of code that was only really needed to deprecate the pre-0.7 global scope behavior, but was hard to tease apart.
So far I have a pretty good first cut that builds and passes test-core and test-syntax. It already fixes some obscure corner cases (see test).