Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force specialization of the SubArray boundserror method. #30666

Merged
merged 1 commit into from
Jan 10, 2019
Merged

Force specialization of the SubArray boundserror method. #30666

merged 1 commit into from
Jan 10, 2019

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Jan 9, 2019

Improves #29867 by avoiding an invoke.
Will run @nanosoldier when CI is green.

@maleadt maleadt added the arrays [a, r, r, a, y, s] label Jan 9, 2019
@maleadt maleadt requested a review from KristofferC January 9, 2019 12:31
@KristofferC
Copy link
Member

See the discussion starting at #29867 (comment).

@maleadt maleadt mentioned this pull request Jan 9, 2019
Merged
@KristofferC KristofferC mentioned this pull request Jan 9, 2019
Merged
15 tasks
@maleadt
Copy link
Member Author

maleadt commented Jan 9, 2019

@nanosoldier runbenchmarks(ALL, vs = ":master")

@maleadt
Copy link
Member Author

maleadt commented Jan 10, 2019

Nanosoldier not feeling well?
@nanosoldier runbenchmarks(ALL, vs = ":master")

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

@KristofferC KristofferC merged commit bb636aa into master Jan 10, 2019
@KristofferC KristofferC deleted the tb/subarray_boundserror_invoke branch January 10, 2019 15:08
@timholy timholy mentioned this pull request Jan 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KristofferC KristofferC KristofferC approved these changes

Assignees
No one assigned
Labels
arrays [a, r, r, a, y, s]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maleadt @KristofferC @nanosoldier