speed up dispatch on parameterized function types #31089
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be a safe subset of #21760. Allows splitting on the type of the function for parameterized types. Does not change dispatch on Types (constructors), since it is not strictly better in that case --- many constructors are abstract types that we can't split on. Improving that case will require a more complex change.
Using the benchmark from #21760:
Before:
After:
(Note we are now able to optimize out the first benchmark completely.)