Make it possible to add optimization passes without lowering intrinsics. #31101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maleadt
added
compiler:codegen
This was referenced Feb 18, 2019
|
Any objections here, @Keno @vtjnash? This would probably only be a temporary thing depending on how #31135 pans out, but it is needed to have StaticArrays work on the GPU again (JuliaGPU/CUDAnative.jl#340). |
|
None from me |
|
Ok with me, but I think we may have to take a good look at this entire thing soon and work out the right abstraction points. |
|
Note to triage, it would be good if we could backport this, it should be low-risk and is a change to an internal API, but technically is a "feature". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of those passes generate CPU-specific code, so add a way to disable them.
CUDAnative is now using its own lowering passes [1], but it might make sense to split some of the existing lowering passes (eg.
LowerGCFrame) into more generic optimization + CPU-specific lowering.1: https://github.com/JuliaGPU/CUDAnative.jl/blob/dc37a71024869034ecb58cfe65c0f9658ea60aa7/src/compiler/optim.jl#L18-L21
cc @jonathanvdc