Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.0] Remove mention of a predicate function in strip docstring #31212

Closed
wants to merge 1 commit into from

Conversation

ararslan
Copy link
Member

lstrip and rstrip take a predicate function as the first argument. It seems strip did not receive that addition, though its docstring suggests that it did.

See #31195. Companion to #31211.

`lstrip` and `rstrip` take a predicate function as the first argument.
It seems `strip` did not receive that addition, though its docstring
suggests that it did.

See #31195.
@ararslan ararslan added docs This change adds or pertains to documentation strings "Strings!" labels Feb 28, 2019
@ararslan
Copy link
Member Author

I guess I should propose the same change against the release-1.1 branch?

@ararslan
Copy link
Member Author

Wait, this was dumb. I should just make this change against master and mark it for backporting, then rebase #31211 atop that once that change lands on master.

@ararslan ararslan closed this Feb 28, 2019
@ararslan ararslan deleted the aa/no-strip-pred-1.0 branch February 28, 2019 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This change adds or pertains to documentation strings "Strings!"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant