Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document undocumented exports and add Examples #31225

Merged
merged 2 commits into from
Mar 3, 2019
Merged

Document undocumented exports and add Examples #31225

merged 2 commits into from
Mar 3, 2019

Conversation

kshyatt
Copy link
Contributor

@kshyatt kshyatt commented Mar 1, 2019

No description provided.

@kshyatt kshyatt added docs This change adds or pertains to documentation io Involving the I/O subsystem: libuv, read, write, etc. labels Mar 1, 2019
@mbauman mbauman mentioned this pull request Mar 1, 2019
Closed
@kshyatt
Copy link
Contributor Author

kshyatt commented Mar 1, 2019

Lol whoops put these in the wrong place, didn't I... pre ☕️ commits are a problem

@kshyatt
Copy link
Contributor Author

kshyatt commented Mar 1, 2019

Or maybe not... perhaps post ☕️ comments are a problem too...

@fredrikekre @kshyatt
Update stdlib/Sockets/src/IPAddr.jl
5f3e000 
Co-Authored-By: kshyatt <kshyatt@users.noreply.github.com>
@StefanKarpinski StefanKarpinski merged commit b845b06 into master Mar 3, 2019
@StefanKarpinski StefanKarpinski deleted the ksh/sockdoc branch March 3, 2019 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredrikekre fredrikekre fredrikekre left review comments

@StefanKarpinski StefanKarpinski StefanKarpinski approved these changes

Assignees
No one assigned
Labels
docs This change adds or pertains to documentation io Involving the I/O subsystem: libuv, read, write, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kshyatt @StefanKarpinski @fredrikekre