Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs for PosDefException and SingularException #31251

Merged
merged 1 commit into from
Mar 5, 2019
Merged

Docs for PosDefException and SingularException #31251

merged 1 commit into from
Mar 5, 2019

Conversation

kshyatt
Copy link
Contributor

@kshyatt kshyatt commented Mar 4, 2019

No description provided.

@kshyatt kshyatt added docs This change adds or pertains to documentation linear algebra Linear algebra labels Mar 4, 2019
@kshyatt kshyatt requested a review from andreasnoack March 4, 2019 20:39
@mbauman mbauman mentioned this pull request Mar 4, 2019
Closed
fredrikekre
fredrikekre previously approved these changes Mar 4, 2019
View reviewed changes
stdlib/LinearAlgebra/src/exceptions.jl Outdated
"""
SingularException

The input matrix has one or more zero-valued eigenvalues, and is not invertible.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should describe the exception instead, e.g. "Exception thrown when..."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

stdlib/LinearAlgebra/src/exceptions.jl Outdated
"""
PosDefException

The input matrix was not [positive definite](https://en.wikipedia.org/wiki/Definiteness_of_a_matrix).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@fredrikekre fredrikekre merged commit 9656c44 into master Mar 5, 2019
@fredrikekre fredrikekre deleted the ksh/linalgerrs branch March 5, 2019 10:27
@dkarrasch dkarrasch mentioned this pull request Mar 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredrikekre fredrikekre fredrikekre left review comments

@andreasnoack andreasnoack Awaiting requested review from andreasnoack

Assignees
No one assigned
Labels
docs This change adds or pertains to documentation linear algebra Linear algebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kshyatt @fredrikekre