-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove integer domain example that doesn't work #31298
Conversation
This was fixed by making exponents with integer literals special syntax:
The documentation should reflect this distinction and I just now notice that that error message should probably be updated also. |
Arbitrarily large integer literals are supported. Full stop. |
"\nMake x a float by adding a zero decimal (e.g., 2.0^$p instead ", | ||
"of 2^$p), or write 1/x^$(-p), float(x)^$p, or (x//1)^$p"))) | ||
"\nMake x or $p a float by adding a zero decimal ", | ||
"(e.g., 2.0^$p or 2^$(float(p)) instead of 2^$p), ", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Keno I think this addresses your point about the error message suggestion. It adds a suggestion for 2^-1.0
, as well as calling float on the exponent (i.e. 2^(float(p))
) which should cover the literal and expression cases.
Thank you, and welcome as a contributor to Julia! |
I tried this in julia 1.0.2 and it seems that the interepreter is smart enough now to interpret the expression as a float