Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BoundsError for regex deepcopy #31309

Merged
merged 2 commits into from
Apr 2, 2019
Merged

Fix BoundsError for regex deepcopy #31309

merged 2 commits into from
Apr 2, 2019

Conversation

eulerkochy
Copy link
Contributor

Fixes #31260 , as per #31260 (comment)

@eulerkochy eulerkochy changed the title Fix BoundsError for regex deepcopy [RFC] Fix BoundsError for regex deepcopy Mar 10, 2019
@eulerkochy
Copy link
Contributor Author

@StefanKarpinski @JeffBezanson can you look at this PR?

@StefanKarpinski
Copy link
Member

@JeffBezanson, this is all you. I have no idea if this is kosher or not.

@eulerkochy
Copy link
Contributor Author

Bump

@StefanKarpinski StefanKarpinski added the triage This should be discussed on a triage call label Mar 18, 2019
@StefanKarpinski
Copy link
Member

Triage is cool with this but notes that the regex JIT compile cache isn't threadsafe but that's a problem for another day.

@StefanKarpinski StefanKarpinski removed the triage This should be discussed on a triage call label Mar 28, 2019
@StefanKarpinski
Copy link
Member

Could you add a test as well? You can test that creating a copy doesn't cause a bounds check error.

@StefanKarpinski StefanKarpinski added the needs tests Unit tests are required for this change label Mar 28, 2019
@NHDaly NHDaly mentioned this pull request Mar 28, 2019
Closed
@eulerkochy eulerkochy changed the title [RFC] Fix BoundsError for regex deepcopy Fix BoundsError for regex deepcopy Mar 29, 2019
@eulerkochy
Copy link
Contributor Author

Bump

@StefanKarpinski StefanKarpinski merged commit 719c062 into JuliaLang:master Apr 2, 2019
@StefanKarpinski
Copy link
Member

Thanks for fixing this, @eulerkochy! Nice work.

@vtjnash vtjnash mentioned this pull request Feb 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanKarpinski StefanKarpinski StefanKarpinski approved these changes

@JeffBezanson JeffBezanson Awaiting requested review from JeffBezanson

Assignees
No one assigned
Labels
needs tests Unit tests are required for this change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eulerkochy @StefanKarpinski