doc AbstractWorkerPool #31544
Merged
doc AbstractWorkerPool #31544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshyatt
added
docs
|
@amitmurthy: would be great if you can take a quick look at this doc and approve if it looks good to you! |
amitmurthy
reviewed
Apr 2, 2019
kshyatt
force-pushed
the
ksh/abstractpool
branch
from
8e0791a
to
6cbd7a8
Compare
|
@amitmurthy good to go? |
amitmurthy
approved these changes
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the stuff from the comment because it seems pretty useful if you want to extend this abstract type properly.