Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix potential stack overflow in Profile.jl #31693

Merged
merged 1 commit into from
Apr 12, 2019
Merged

fix potential stack overflow in Profile.jl #31693

merged 1 commit into from
Apr 12, 2019

Conversation

JeffBezanson
Copy link
Member

This will hopefully fix the stack overflow we've seen many times in CI (e.g. https://build.julialang.org/#/builders/13/builds/1552/steps/2/logs/stdio).

@JeffBezanson JeffBezanson added test This change adds or pertains to unit tests ci Continuous integration labels Apr 11, 2019
vtjnash
vtjnash approved these changes Apr 11, 2019
View reviewed changes
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, although I think it'll just push the problem a few lines further, it does fix the first case

@kmsquire kmsquire mentioned this pull request Apr 12, 2019
Merged
@JeffBezanson JeffBezanson merged commit 6308ebd into master Apr 12, 2019
@JeffBezanson JeffBezanson deleted the jb/profilestkovf branch April 12, 2019 14:59
@vtjnash
Copy link
Member

vtjnash commented Apr 16, 2019

Here's where we'll fail now: https://build.julialang.org/#/builders/13/builds/1692/steps/2/logs/stdio (fwiw, I think this is the only other place that needs the same change)

Keno added a commit that referenced this pull request May 1, 2019
@Keno
Prevent stack overflow in Profile
fe45bb1 
As a follow up to #31693, this fixes the other place in Profile
that recurses over Profile data, causing stack overflows. This
should fix a bunch of the recent intermittent CI faults on linux32.
Keno added a commit that referenced this pull request May 1, 2019
@Keno
Prevent stack overflow in Profile
d2e7808 
As a follow up to #31693, this fixes the other place in Profile
that recurses over Profile data, causing stack overflows. This
should fix a bunch of the recent intermittent CI faults on linux32.
@Keno Keno mentioned this pull request May 1, 2019
Merged
Keno added a commit that referenced this pull request May 2, 2019
@Keno
Prevent stack overflow in Profile (#31893)
1707e13 
As a follow up to #31693, this fixes the other place in Profile
that recurses over Profile data, causing stack overflows. This
should fix a bunch of the recent intermittent CI faults on linux32.
@JeffBezanson JeffBezanson mentioned this pull request May 15, 2019
Closed
58 tasks
KristofferC pushed a commit that referenced this pull request May 15, 2019
@JeffBezanson @KristofferC
fix potential stack overflow in Profile.jl (#31693)
4574af8 
(cherry picked from commit 6308ebd)
KristofferC pushed a commit that referenced this pull request May 15, 2019
@Keno @KristofferC
Prevent stack overflow in Profile (#31893)
9fa5ea8 
As a follow up to #31693, this fixes the other place in Profile
that recurses over Profile data, causing stack overflows. This
should fix a bunch of the recent intermittent CI faults on linux32.

(cherry picked from commit 1707e13)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

Assignees
No one assigned
Labels
ci Continuous integration test This change adds or pertains to unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JeffBezanson @vtjnash @KristofferC