Backports for 1.2-RC1

.travis.yml

@@ -61,7 +61,7 @@ before_install:
         ln -s /usr/bin/g++-5 $HOME/bin/x86_64-linux-gnu-g++;
         gcc --version;
         BAR="bar -i 30";
-        BUILDOPTS="-j5 VERBOSE=1 FORCE_ASSERTIONS=1 LLVM_ASSERTIONS=1 USECCACHE=1 USE_BINARYBUILDER_LIBUV=0 USE_BINARYBUILDER_UNWIND=0 USE_BINARYBUILDER_LLVM=0";
+        BUILDOPTS="-j5 VERBOSE=1 FORCE_ASSERTIONS=1 LLVM_ASSERTIONS=1 USECCACHE=1 USE_BINARYBUILDER_LIBUV=0 USE_BINARYBUILDER_LIBUNWIND=0 USE_BINARYBUILDER_LLVM=0";
         echo "override ARCH=$ARCH" >> Make.user;
         sudo sh -c "echo 0 > /proc/sys/net/ipv6/conf/lo/disable_ipv6";
         export JULIA_CPU_THREADS=4;

Make.inc

@@ -14,6 +14,8 @@
 # Set to zero to turn off extra precompile (e.g. for the REPL)
 JULIA_PRECOMPILE ?= 1
 
+FORCE_ASSERTIONS ?= 0
+
 # OPENBLAS build options
 OPENBLAS_TARGET_ARCH:=
 OPENBLAS_SYMBOLSUFFIX:=
@@ -927,7 +929,7 @@ else
 endif
 
 # BinaryBuilder options.  We default to "on" for all the projects listed in BB_PROJECTS,
-# but only if contrib/normalize_triplet.py works for our requested triplet
+# but only if contrib/normalize_triplet.py works for our requested triplet.
 ifeq ($(shell python $(JULIAHOME)/contrib/normalize_triplet.py $(or $(XC_HOST),$(XC_HOST),$(BUILD_MACHINE)) >/dev/null 2>/dev/null; echo $$?),0)
 USE_BINARYBUILDER := 1
 else
@@ -937,9 +939,39 @@ endif
 USE_BINARYBUILDER := 0
 endif
 
+# GMP and MPFR have serious performance regressions for now
+USE_BINARYBUILDER_GMP ?= 0
+USE_BINARYBUILDER_MPFR ?= 0
+
 # This is the set of projects that BinaryBuilder dependencies are hooked up for.
-BB_PROJECTS := OPENBLAS LLVM SUITESPARSE OPENLIBM GMP MBEDTLS LIBSSH2 MPFR CURL LIBGIT2 PCRE LIBUV UNWIND
-$(foreach proj,$(BB_PROJECTS),$(if $(USE_BINARYBUILDER_$(proj)),,$(eval USE_BINARYBUILDER_$(proj) := $(USE_BINARYBUILDER))))
+BB_PROJECTS := OPENBLAS LLVM SUITESPARSE OPENLIBM MBEDTLS LIBSSH2 CURL LIBGIT2 PCRE LIBUV UNWIND
+define SET_BB_DEFAULT
+# First, check to see if BB is disabled on a global setting
+ifeq ($$(USE_BINARYBUILDER),0)
+USE_BINARYBUILDER_$(1) ?= 0
+else
+# If it's not, check to see if it's disabled by a USE_SYSTEM_xxx flag
+ifeq ($$(USE_SYSTEM_$(1)),1)
+USE_BINARYBUILDER_$(1) ?= 0
+else
+USE_BINARYBUILDER_$(1) ?= 1
+endif
+endif
+endef
+$(foreach proj,$(BB_PROJECTS),$(eval $(call SET_BB_DEFAULT,$(proj))))
+
+# Some special restrictions on BB usage:
+ifeq ($(USE_SYSTEM_BLAS),1)
+# Since the names don't line up (`BLAS` vs. `OPENBLAS`), manually gate:
+USE_BINARYBUILDER_OPENBLAS ?= 0
+# Disable BB SuiteSparse if we're using system BLAS
+USE_BINARYBUILDER_SUITESPARSE ?= 0
+endif
+
+ifeq ($(USE_SYSTEM_LIBM),1)
+# If we're using system libm, disable BB OpenLibm
+USE_BINARYBUILDER_OPENLIBM ?= 0
+endif
 
 # Use the Assertions build
 BINARYBUILDER_LLVM_ASSERTS := 0

NEWS.md

@@ -4,104 +4,90 @@ Julia v1.2 Release Notes
 New language features
 ---------------------
 
-  * Argument splatting (`x...`) can now be used in calls to the `new` pseudo-function in
-    constructors ([#30577]).
-
-  * Objects created by calling `skipmissing` on an array can now be indexed using indices
-    from the parent at non-missing positions. This allows functions such as
-    `findall`, `findfirst`, `argmin`/`argmax` and `findmin`/`findmax` to work with these
-    objects, returning the index of matching non-missing elements in the parent ([#31008]).
-
-  * `inv(::Missing)` has now been added and returns `missing` ([#31451]).
+* Argument splatting (`x...`) can now be used in calls to the `new` pseudo-function in
+  constructors ([#30577]).
+* Support for Unicode 12.0.0 ([#31561]).
+* Added `⋆` (`\star`) as unary operator ([#31604]).
 
-  * `nextfloat(::BigFloat, n::Integer)` and `prevfloat(::BigFloat, n::Integer)` methods
-    have been added ([#31310]).
+Language changes
+----------------
 
-  * Support for Unicode 12.0.0 ([#31561]).
+* Empty entries in `JULIA_DEPOT_PATH` are now expanded to default depot entries ([#31009]).
 
 Multi-threading changes
 -----------------------
 
 * The `Condition` type now has a thread-safe replacement, accessed as `Threads.Condition`.
-    With that addition, task scheduling primitives such as `ReentrantLock` are now thread-safe ([#30061]).
-
-  * It is possible to schedule and switch Tasks during `@threads` loops, and perform limited I/O ([#31438]).
-
-Language changes
-----------------
-* Empty entries in `JULIA_DEPOT_PATH` are now expanded to default depot entries ([#31009]).
-* `Enum` now behaves like a scalar when used in broadcasting ([#30670]).
-* If a `pipeline` is specified with `append=true` set, but no redirection, an `ArgumentError`
-is thrown, rather than a `ErrorException` ([#27900]).
-* Functions that invoke commands (e.g. `run(::Cmd)`) now throw a `ProcessFailedException`
-rather than an `ErrorException`, if those commands exit with non-zero exit code.
-([#27900]).
-* Added `⋆` (`\star`) as unary operator ([#31604]).
+  With that addition, task scheduling primitives such as `ReentrantLock` are now thread-safe ([#30061]).
+* It is possible to schedule and switch Tasks during `@threads` loops, and perform limited I/O ([#31438]).
 
-Command-line option changes
----------------------------
+Build system changes
+--------------------
 
+* The build system now prefers downloading prebuilt binary tarballs for most dependencies on
+  supported systems, disable by setting `USE_BINARYBUILDER=0` at `make` time ([#31441]).
 
 New library functions
 ---------------------
 
-* `getipaddrs()` function returns all the IP addresses of the local machine, with IPv4 addresses sorting before IPv6 addresses ([#30349, #30604])
-* `getipaddr(addr_type)` and `getipaddrs(addr_type)` functions returns an IP address(es) of the desired type of the local machine ([#30604])
+* `getipaddrs()` function returns all the IP addresses of the local machine, with IPv4 addresses sorting before IPv6 addresses ([#30349, #30604]).
+* `getipaddr(addr_type)` and `getipaddrs(addr_type)` functions returns an IP address(es) of the desired type of the local machine ([#30604]).
 * Added `Base.hasproperty` and `Base.hasfield` ([#28850]).
-* One argument `!=(x)`, `>(x)`, `>=(x)`, `<(x)`, `<=(x)` has been added for currying,
-  similar to the existing `==(x)` and `isequal(x)` methods ([#30915]).
+* One argument `!=(x)`, `>(x)`, `>=(x)`, `<(x)`, `<=(x)` have been added, returning partially-applied
+  versions of the functions, similar to the existing `==(x)` and `isequal(x)` methods ([#30915]).
 
 Standard library changes
 ------------------------
 
+* `Enum` now behaves like a scalar when used in broadcasting ([#30670]).
+* If a `pipeline` is specified with `append=true` set, but no redirection, an `ArgumentError`
+  is thrown, rather than a `ErrorException` ([#27900]).
+* Functions that invoke commands (e.g. `run(::Cmd)`) now throw a `ProcessFailedException`
+  rather than an `ErrorException`, if those commands exit with non-zero exit code ([#27900]).
 * The `extrema` function now accepts a function argument in the same manner as `minimum` and
   `maximum` ([#30323]).
 * `hasmethod` can now check for matching keyword argument names ([#30712]).
 * `startswith` and `endswith` now accept a `Regex` for the second argument ([#29790]).
 * `retry` supports arbitrary callable objects ([#30382]).
-* `filter` now supports `SkipMissing`-wrapped arrays ([#31235]).
-* A no-argument construct to `Ptr{T}` has been added which constructs a null pointer ([#30919])
-* `strip` now accepts a function argument in the same manner as `lstrip` and `rstrip` ([#31211])
-* `mktempdir` now accepts a `prefix` keyword argument to customize the file name ([#31230], [#22922])
+* A no-argument constructor for `Ptr{T}` has been added which constructs a null pointer ([#30919]).
+* `strip` now accepts a function argument in the same manner as `lstrip` and `rstrip` ([#31211]).
+* `mktempdir` now accepts a `prefix` keyword argument to customize the file name ([#31230], [#22922]).
 * `keytype` and `valtype` now work on `AbstractArray`, and return the `eltype` of `keys(...)` and
   `values(...)` respectively ([#27749]).
 * `nextfloat(::BigFloat)` and `prevfloat(::BigFloat)` now returns a value with the same precision
   as their argument, which means that (in particular) `nextfloat(prevfloat(x)) == x` whereas
-  previously this could result in a completely different value with a different precision ([#31310])
-* `mapreduce` now accept multiple iterators, similar to `map` ([#31532]).
+  previously this could result in a completely different value with a different precision ([#31310]).
+* `mapreduce` now accepts multiple iterators, similar to `map` ([#31532]).
+* `filter` now supports `SkipMissing`-wrapped arrays ([#31235]).
+* Objects created by calling `skipmissing` on an array can now be indexed using indices
+  from the parent at non-missing positions. This allows functions such as
+  `findall`, `findfirst`, `argmin`/`argmax` and `findmin`/`findmax` to work with these
+  objects, returning the index of matching non-missing elements in the parent ([#31008]).
+* `inv(::Missing)` has now been added and returns `missing` ([#31451]).
+* `nextfloat(::BigFloat, n::Integer)` and `prevfloat(::BigFloat, n::Integer)` methods
+  have been added ([#31310]).
 
 #### LinearAlgebra
-
 * Added keyword arguments `rtol`, `atol` to `pinv` and `nullspace` ([#29998]).
 * `UniformScaling` instances are now callable such that e.g. `I(3)` will produce a `Diagonal` matrix ([#30298]).
 * Eigenvalues λ of general matrices are now sorted lexicographically by (Re λ, Im λ) ([#21598]).
 * `one` for structured matrices (`Diagonal`, `Bidiagonal`, `Tridiagonal`, `Symtridiagonal`) now preserves
-  structure and type. ([#29777])
-* `diagm(v)` is now a shorthand for `diagm(0 => v)`. ([#31125]).
+  structure and type ([#29777]).
+* `diagm(v)` is now a shorthand for `diagm(0 => v)` ([#31125]).
 
 #### SparseArrays
-
-* performance improvements for sparse matrix-matrix multiplication ([#30372]).
+* Performance improvements for sparse matrix-matrix multiplication ([#30372]).
 * Sparse vector outer products are more performant and maintain sparsity in products of the
   form `kron(u, v')`, `u * v'`, and `u .* v'` where `u` and `v` are sparse vectors or column
-  views. ([#24980])
-
-#### Dates
-
-* Fixed `repr` such that it displays `DateTime` as it would be entered in Julia ([#30200]).
+  views ([#24980]).
 
 #### Statistics
-
 * `quantile` now accepts in all cases collections whose `eltype` is not a subtype of `Number` ([#30938]).
 
 #### Miscellaneous
-
 * Since environment variables on Windows are case-insensitive, `ENV` now converts its keys
   to uppercase for display, iteration, and copying ([#30593]).
 
-* Build system now prefers downloading prebuilt binary tarballs for most dependencies on
-  supported systems, disable by setting `USE_BINARYBUILDER=0` at `make` time ([#31441]).
-
 External dependencies
 ---------------------
 
@@ -110,20 +96,17 @@ External dependencies
 * MbedTLS has been updated to v2.16.0 ([#30618]).
 * libunwind has been updated to v1.3.1 ([#30724]).
 
-Deprecated or removed
----------------------
-
-
 <!--- generated by NEWS-update.jl: -->
 [#21598]: https://github.com/JuliaLang/julia/issues/21598
 [#22922]: https://github.com/JuliaLang/julia/issues/22922
 [#24980]: https://github.com/JuliaLang/julia/issues/24980
+[#27749]: https://github.com/JuliaLang/julia/issues/27749
+[#27900]: https://github.com/JuliaLang/julia/issues/27900
 [#28850]: https://github.com/JuliaLang/julia/issues/28850
 [#29777]: https://github.com/JuliaLang/julia/issues/29777
 [#29790]: https://github.com/JuliaLang/julia/issues/29790
 [#29998]: https://github.com/JuliaLang/julia/issues/29998
 [#30061]: https://github.com/JuliaLang/julia/issues/30061
-[#30200]: https://github.com/JuliaLang/julia/issues/30200
 [#30298]: https://github.com/JuliaLang/julia/issues/30298
 [#30323]: https://github.com/JuliaLang/julia/issues/30323
 [#30372]: https://github.com/JuliaLang/julia/issues/30372
@@ -147,6 +130,9 @@ Deprecated or removed
 [#31230]: https://github.com/JuliaLang/julia/issues/31230
 [#31235]: https://github.com/JuliaLang/julia/issues/31235
 [#31310]: https://github.com/JuliaLang/julia/issues/31310
+[#31438]: https://github.com/JuliaLang/julia/issues/31438
 [#31441]: https://github.com/JuliaLang/julia/issues/31441
 [#31451]: https://github.com/JuliaLang/julia/issues/31451
 [#31532]: https://github.com/JuliaLang/julia/issues/31532
+[#31561]: https://github.com/JuliaLang/julia/issues/31561
+[#31604]: https://github.com/JuliaLang/julia/issues/31604

VERSION

@@ -1 +1 @@
-1.2.0-pre
+1.2.0-rc1

base/asyncevent.jl

@@ -13,11 +13,11 @@ Use [`isopen`](@ref) to check whether it is still active.
 """
 mutable struct AsyncCondition
     handle::Ptr{Cvoid}
-    cond::Condition
+    cond::ThreadSynchronizer
     isopen::Bool
 
     function AsyncCondition()
-        this = new(Libc.malloc(_sizeof_uv_async), Condition(), true)
+        this = new(Libc.malloc(_sizeof_uv_async), ThreadSynchronizer(), true)
         associate_julia_struct(this.handle, this)
         finalizer(uvfinalize, this)
         err = ccall(:uv_async_init, Cint, (Ptr{Cvoid}, Ptr{Cvoid}, Ptr{Cvoid}),
@@ -41,14 +41,22 @@ the async condition object itself.
 function AsyncCondition(cb::Function)
     async = AsyncCondition()
     waiter = Task(function()
-        while isopen(async)
-            success = try
-                wait(async)
-                true
-            catch exc # ignore possible exception on close()
-                isa(exc, EOFError) || rethrow()
+        lock(async.cond)
+        try
+            while isopen(async)
+                success = try
+                    stream_wait(async, async.cond)
+                    true
+                catch exc # ignore possible exception on close()
+                    isa(exc, EOFError) || rethrow()
+                finally
+                    unlock(async.cond)
+                end
+                success && cb(async)
+                lock(async.cond)
             end
-            success && cb(async)
+        finally
+            unlock(async.cond)
         end
     end)
     # must start the task right away so that it can wait for the AsyncCondition before
@@ -71,14 +79,14 @@ to check whether a timer is still active.
 """
 mutable struct Timer
     handle::Ptr{Cvoid}
-    cond::Condition
+    cond::ThreadSynchronizer
     isopen::Bool
 
     function Timer(timeout::Real; interval::Real = 0.0)
         timeout ≥ 0 || throw(ArgumentError("timer cannot have negative timeout of $timeout seconds"))
         interval ≥ 0 || throw(ArgumentError("timer cannot have negative repeat interval of $interval seconds"))
 
-        this = new(Libc.malloc(_sizeof_uv_timer), Condition(), true)
+        this = new(Libc.malloc(_sizeof_uv_timer), ThreadSynchronizer(), true)
         err = ccall(:uv_timer_init, Cint, (Ptr{Cvoid}, Ptr{Cvoid}), eventloop(), this)
         if err != 0
             #TODO: this codepath is currently not tested
@@ -102,8 +110,13 @@ unsafe_convert(::Type{Ptr{Cvoid}}, t::Timer) = t.handle
 unsafe_convert(::Type{Ptr{Cvoid}}, async::AsyncCondition) = async.handle
 
 function wait(t::Union{Timer, AsyncCondition})
-    isopen(t) || throw(EOFError())
-    stream_wait(t, t.cond)
+    lock(t.cond)
+    try
+        isopen(t) || throw(EOFError())
+        stream_wait(t, t.cond)
+    finally
+        unlock(t.cond)
+    end
 end
 
 isopen(t::Union{Timer, AsyncCondition}) = t.isopen
@@ -128,24 +141,39 @@ function uvfinalize(t::Union{Timer, AsyncCondition})
 end
 
 function _uv_hook_close(t::Union{Timer, AsyncCondition})
-    uvfinalize(t)
-    notify_error(t.cond, EOFError())
+    lock(t.cond)
+    try
+        uvfinalize(t)
+        notify_error(t.cond, EOFError())
+    finally
+        unlock(t.cond)
+    end
     nothing
 end
 
 function uv_asynccb(handle::Ptr{Cvoid})
     async = @handle_as handle AsyncCondition
-    notify(async.cond)
+    lock(async.cond)
+    try
+        notify(async.cond)
+    finally
+        unlock(async.cond)
+    end
     nothing
 end
 
 function uv_timercb(handle::Ptr{Cvoid})
     t = @handle_as handle Timer
-    if ccall(:uv_timer_get_repeat, UInt64, (Ptr{Cvoid},), t) == 0
-        # timer is stopped now
-        close(t)
+    lock(t.cond)
+    try
+        if ccall(:uv_timer_get_repeat, UInt64, (Ptr{Cvoid},), t) == 0
+            # timer is stopped now
+            close(t)
+        end
+        notify(t.cond)
+    finally
+        unlock(t.cond)
     end
-    notify(t.cond)
     nothing
 end
 

base/boot.jl

@@ -557,7 +557,7 @@ eval(Core, :(NamedTuple{names,T}(args::T) where {names, T <: Tuple} =
 
 import .Intrinsics: eq_int, trunc_int, lshr_int, sub_int, shl_int, bitcast, sext_int, zext_int, and_int
 
-throw_inexacterror(f::Symbol, @nospecialize(T), val) = (@_noinline_meta; throw(InexactError(f, T, val)))
+throw_inexacterror(f::Symbol, ::Type{T}, val) where {T} = (@_noinline_meta; throw(InexactError(f, T, val)))
 
 function is_top_bit_set(x)
     @_inline_meta