Revert "Don't use jl_rethrow_other for LoadError/InitError" (fix #31830) #31963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d3dbe86. + fixup new tests in backtrace.jl
c42f
added
bugfix
|
So this commit should be backported? |
|
@KristofferC pending review, yes. Actually I'm unsure: do you prefer the backport label to be added immediately for fixes which are specifically related to release, or once the PR has merged? |
|
Backport label can be added directly for things that should be backported. They get backported when the PR is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #31830 in the simplest way possible by reverting commit d3dbe86 + fixup new tests in backtrace.jl
This fix is for expediency and stability in the julia-1.2 release (see #31882 (comment), #31882 (comment)); I expect we will move forward with #31882 in julia-1.3 as a better way to clean up this code.