Avoid segfault when ptls->safepoint is NULL (rebased #27020) #32254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mmm. That all-green CI! |
benlorenz
force-pushed
the
fix/gc-segfault-rebased
branch
from
54e31f6 to
6c5242b
Compare
There are cases (eg: when __gmpz_init is called from python via PyCall in a secondary thread) where ptls->safepoint is NULL when maybe_collect is called, and *ptls->safepoint causes a NULL pointer dereference and a segfault. This change fixes that case. Included test in test/threads.jl that will reproduce this issue. See JuliaLang#27020 for backtrace and more details
benlorenz
force-pushed
the
fix/gc-segfault-rebased
branch
from
6c5242b to
4af4411
Compare
|
I rebased the branch onto the current master again and put the now thread-local gc counters into the if statement as well. |
|
I guess this is superseded by #33284? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same as #27020 but rebased onto the current master. There were positive reviews but some CI issues at the time, lets hope it is better this time.
We have hit this issue with an external library that creates openmp threads which trigger the gc via gmp allocations.