readdlm(bytearray) shouldn't modify bytearray #32255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually |
|
We have |
|
Oh wait, of course that isn't possible in general. And in fact, the current code already makes a copy sometimes, if the Vector isn't backed by a String. We can instead change it to always make 1 copy (instead of 1 or 2) using |
JeffBezanson
reviewed
Jun 6, 2019
Co-Authored-By: Jeff Bezanson <jeff.bezanson@gmail.com>
|
Good to merge? |
|
Fine with me. |
KristofferC
pushed a commit
that referenced
this pull request
Jun 9, 2019
* readdlm(bytearray) shouldn't modify bytearray * Update stdlib/DelimitedFiles/src/DelimitedFiles.jl Co-Authored-By: Jeff Bezanson <jeff.bezanson@gmail.com> (cherry picked from commit 7038210)
KristofferC
pushed a commit
that referenced
this pull request
Aug 26, 2019
* readdlm(bytearray) shouldn't modify bytearray * Update stdlib/DelimitedFiles/src/DelimitedFiles.jl Co-Authored-By: Jeff Bezanson <jeff.bezanson@gmail.com> (cherry picked from commit 7038210)
55 tasks
KristofferC
pushed a commit
that referenced
this pull request
Aug 26, 2019
* readdlm(bytearray) shouldn't modify bytearray * Update stdlib/DelimitedFiles/src/DelimitedFiles.jl Co-Authored-By: Jeff Bezanson <jeff.bezanson@gmail.com> (cherry picked from commit 7038210)
KristofferC
pushed a commit
that referenced
this pull request
Feb 20, 2020
* readdlm(bytearray) shouldn't modify bytearray * Update stdlib/DelimitedFiles/src/DelimitedFiles.jl Co-Authored-By: Jeff Bezanson <jeff.bezanson@gmail.com> (cherry picked from commit 7038210)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug reported in #16731 (comment) by @bkamins.
(Would be nice to do this without making a copy of the data, but I don't see any way to do this without adding a new C routine.)