Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FMA_NATIVE constant #32318

Merged
merged 1 commit into from
Jun 14, 2019
Merged

Fix FMA_NATIVE constant #32318

merged 1 commit into from
Jun 14, 2019

Conversation

simonbyrne
Copy link
Contributor

As pointed out be @StefanKarpinski in #31922 (comment)

@simonbyrne simonbyrne merged commit 50306e0 into master Jun 14, 2019
@simonbyrne simonbyrne deleted the sb/fma-native branch June 14, 2019 18:44
@chriselrod
Copy link
Contributor

chriselrod commented Mar 1, 2020

Is it really fixed?

julia> Base.Math.FMA_NATIVE
false

julia> @code_native debuginfo=:none fma(1.0, 2.0, 3.0)
        .text
        vfmadd213sd     %xmm2, %xmm1, %xmm0 # xmm0 = (xmm1 * xmm0) + xmm2
        retq
        nopw    %cs:(%rax,%rax)

julia> versioninfo()
Julia Version 1.5.0-DEV.362
Commit 6dd9f418ef (2020-02-28 22:34 UTC)
Platform Info:
  OS: Linux (x86_64-generic-linux)
  CPU: Intel(R) Core(TM) i9-10980XE CPU @ 3.00GHz

EDIT:
Although, I am not sure what is going on, because:

julia> muladd(nextfloat(1.0),nextfloat(1.0),-nextfloat(1.0,2))
4.930380657631324e-32

julia> muladd(nextfloat(1.0),nextfloat(1.0),-nextfloat(1.0,2)) != 0
true

Anyone have any idea how I can investigate this?

@KristofferC
Copy link
Member

#33011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants