Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Channel constructors, change kwargs to positional args. #32818

Merged
merged 6 commits into from
Aug 11, 2019
Merged

Simplify Channel constructors, change kwargs to positional args. #32818

merged 6 commits into from
Aug 11, 2019

Commits on Aug 7, 2019

  1. Fix method overwrite warning for Channel constructors 

    Oops, fixes this error, introduced in e891bca:
WARNING: Method definition (::Type{Base.Channel{T}})(Function) where {T} in module Base at channels.jl:133 overwritten at channels.jl:136.
    @NHDaly
    NHDaly committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    d2c8796 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2019

  1. Make Channel constructors interface more Julian 

    "Soft" deprecation of the old `Channel(f::Function; csize=0, ctype=Any)`
style in favor of the new `Channel{T=Any}(f::Function, size=0)`
interface.

Removed the old interface from the docs, so that it is not discoverable,
and included a `!!! compat` note that the new interface is new in Julia
1.3, and the old interface should not be used.
    @NHDaly
    NHDaly committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    045ac09 View commit details
    Browse the repository at this point in the history

  2. Fix test/channels.jl to use newer Channel constructor

    @NHDaly
    NHDaly committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    3a547d0 View commit details
    Browse the repository at this point in the history

  3. Added new Channel constructor to news

    @NHDaly
    NHDaly committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    b04fb84 View commit details
    Browse the repository at this point in the history

  4. Add Channel(f, size) = Channel{Any}(...) for default T for task const… 

    …ructor
    @NHDaly
    NHDaly committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    26b3e1c View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into Channel-constructors

    @NHDaly
    NHDaly committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    0d296b1 View commit details
    Browse the repository at this point in the history