make generate_precompile a little more robust #32850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
reviewed
Aug 12, 2019
| @@ -138,6 +138,10 @@ function generate_precompile_statements() | |||
| statements = Set{String}() | |||
| for statement in eachline(precompile_file_h) | |||
| occursin("Main.", statement) && continue | |||
| # check for `#x##s66` style variable names not in quotes | |||
| occursin(r"#\w", statement) && | |||
There was a problem hiding this comment.
Might have been better to put around line 166 where the other workarounds are.
There was a problem hiding this comment.
Sure. Maybe a comment to clarify that this is where the workarounds live?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs the
count(regex, string)method added in #32849. Only the last commit needs review for this PR since the other commit is in that PR.