Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

div with rounding modes [+ rounded division] #33040

Merged
merged 8 commits into from
Sep 28, 2019
Merged

div with rounding modes [+ rounded division] #33040

merged 8 commits into from
Sep 28, 2019

Commits on Sep 25, 2019

  1. Re-arrange fld/cld code 

    In preparation for supporting other rounding modes in div, create
a three-argument div function that takes a rounding mode as the last
argument and make this the fundamental fallback for fld/cld.
    @Keno
    Keno committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    8ebb4e4 View commit details
    Browse the repository at this point in the history

  2. Implemented rounded division

    @Keno
    Keno committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    c00c706 View commit details
    Browse the repository at this point in the history

  3. add various divrem combinations to avoid overflow

    @simonbyrne @Keno
    simonbyrne authored and Keno committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    cb51af0 View commit details
    Browse the repository at this point in the history

  4. Whitespace/test fixes

    @Keno
    Keno committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    f6f8795 View commit details
    Browse the repository at this point in the history

  5. Small tweaks to docstrings

    @Keno
    Keno committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    14c2683 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2019

  1. Bugfixes

    @Keno
    Keno committed Sep 26, 2019
    Configuration menu
    Copy the full SHA
    bcb5605 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2019

  1. Add the exhaustive test

    @Keno
    Keno committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    dba98bb View commit details
    Browse the repository at this point in the history

  2. Tigthen up types for div fallback 

    I think it's better to give a MethodError here than an approximate
answer for non-AbstractFloat reals (e.g. custom integer types).
    @Keno
    Keno committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    f85ebed View commit details
    Browse the repository at this point in the history