readdir: default to "." or pwd() depending on join keyword #33175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfourquet
approved these changes
Sep 5, 2019
StefanKarpinski
commented
Sep 5, 2019
test/file.jl
Outdated
| @test !ispath(d) | ||
| @test isempty(readdir()) | ||
| @test_throws SystemError readdir(d) | ||
| @test_throws Base.IOError readdir(join=true) |
There was a problem hiding this comment.
It's kind of nasty that these throw different errors: the SystemError comes from trying to call readdir on a non-existend directory whereas the Base.IOError comes from trying to do pwd() in a deleted directory.
|
What is going on with the tests? The failures do not seem related to this change. |
StefanKarpinski
force-pushed
the
sk/readdir
branch
from
e47af02 to
2b1d8ac
Compare
This is a pretty niche issue but it allows `readdir()` to work after the current working direcotory has been deleted, whereas when `join=true` you need a path which no longer exists, so `pwd()` fails and so `readdir(join=true)` also fails.
StefanKarpinski
force-pushed
the
sk/readdir
branch
from
2b1d8ac to
8832fa8
Compare
|
I don't see how this Win32 failure could be caused by this change, but I don't want to merge this and break Win32. Anyone know if this is a thing that's been happening otherwise? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty niche issue but it allows
readdir()to work after the current working direcotory has been deleted, whereas whenjoin=trueyou need a path which no longer exists, sopwd()fails and thereforereaddir(join=true)also fails.I can't find a way to get a current working directory that is both deleted and non-empty:
rm -rin which case it deletes the file before deleting the directory)