tempdir: error on non-directory result #33593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanKarpinski
force-pushed
the
sk/tempdir
branch
from
6cb5d18
to
5f0d075
Compare
StefanKarpinski
referenced
this pull request
Jan 28, 2020
Fixes the Windows tempdir function returning a path with the trailing slash.
|
Should this also check if the directory is writable, and raise an exception if the user doesn't have write permissions? |
musm
reviewed
Sep 25, 2020
|
Bump |
vtjnash
reviewed
Sep 28, 2022
vtjnash
reviewed
Sep 28, 2022
vtjnash
reviewed
Sep 28, 2022
vtjnash
reviewed
Feb 10, 2024
vtjnash
added
the
status:merge me
giordano
removed
the
status:merge me
fatteneder
added a commit
to fatteneder/julia
that referenced
this pull request
Feb 17, 2024
fatteneder
added a commit
that referenced
this pull request
Feb 17, 2024
Warnings were introduced in #33593.
KristofferC
pushed a commit
that referenced
this pull request
Feb 26, 2024
(cherry picked from commit 4990429)
tecosaur
pushed a commit
to tecosaur/julia
that referenced
this pull request
Mar 4, 2024
tecosaur
pushed a commit
to tecosaur/julia
that referenced
this pull request
Mar 4, 2024
Warnings were introduced in JuliaLang#33593.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential more graceful handling of #33382. I thought about creating the directory if it doesn't exist, but that seems aa bit questionable. Probably better to let the user know about the situation in a clear way so they can mitigate it. An even better improvement would be if we could tell them which environment variable to look at. I tried setting
TEMPin the environment on macOS but it didn't seem to have any effect on the result.