(RFC) Show now handles ; in a tuple
#33627
Conversation
c42f
added
the
display and printing
base/show.jl
Outdated
| @@ -1168,7 +1168,13 @@ function show_unquoted(io::IO, ex::Expr, indent::Int, prec::Int) | |||
| sep = ", " | |||
| end | |||
| head !== :row && print(io, op) | |||
| show_list(io, args, sep, indent) | |||
| if isa(args[1], Expr) && args[1].head === :parameters | |||
There was a problem hiding this comment.
You can use Meta.isexpr(args[1], :parameters) for this.
|
Thanks for the response! I totally forgot about empty tuples, it has been updated now. |
|
Oh, it appears that The easiest fix is to go back to using the explicit version without |
test/show.jl
Outdated
| @@ -753,6 +753,9 @@ test_mt(show_f5, "show_f5(A::AbstractArray{T,N}, indices::Vararg{$Int,N})") | |||
| @test_repr "[a;]" | |||
| @test_repr "[a; b]" | |||
|
|
|||
| # Issue #32775, printing ; in a tuple | |||
| @test sprint(show, :((a,;b))) == ":((a; b))" | |||
There was a problem hiding this comment.
This printing is incorrect; (a,; b) and (a; b) are different (the comma makes it a tuple).
There was a problem hiding this comment.
Maybe I'm missing something, but wouldn't Julia parse (a; b) as a block?
There was a problem hiding this comment.
Right, that's the point—these syntaxes are not equivalent:
julia> Meta.@dump (a; b)
Expr
head: Symbol block
args: Array{Any}((3,))
1: Symbol a
2: LineNumberNode
line: Int64 1
file: Symbol REPL[53]
3: Symbol b
julia> Meta.@dump (a,; b)
Expr
head: Symbol tuple
args: Array{Any}((2,))
1: Expr
head: Symbol parameters
args: Array{Any}((1,))
1: Symbol b
2: Symbol a
|
Taken care of by #34038 |
Fix #32775