Revert the accidentally breaking part of 33779 #33925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A one-line change introduced in 33779 seems to have inadvertently caused the regression noted in 33919. Reverting just that part should fix it.
KristofferC
pushed a commit
that referenced
this pull request
Nov 25, 2019
A one-line change introduced in 33779 seems to have inadvertently caused the regression noted in 33919. Reverting just that part should fix it. (cherry picked from commit 76ebc41)
KristofferC
pushed a commit
that referenced
this pull request
Apr 11, 2020
A one-line change introduced in 33779 seems to have inadvertently caused the regression noted in 33919. Reverting just that part should fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A one-line change introduced in #33779 seems to have inadvertently caused the regression noted in #33919. Reverting just that part should fix it.
Fixes #33919.