-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ccall: report static compile-time load issues correctly #34062
Conversation
Confirmed this fixes the original use-case that caused me to file #34061. |
Pushed a test |
2792389
to
8375ede
Compare
Ready to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test may be too slow (adds maybe 1 to 4 minutes) for something fairly trivial
@KristofferC You didn't address my review comment. Also, please cleanup up the commit messages when merging. |
Strange, I completely missed that comment. I can change it to the fast fail version. |
* ccall: report static compile-time load issues correctly fix #34061 * add a test * Update ccall.jl
fix #34061
Should have a test added that checks that something like:
doesn't crash, or that calling
f()
exits the process early (no output-o file) with the message: