fix codegen for getfield of homogeneous tuples #34243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
compiler:codegen
vtjnash
approved these changes
Jan 3, 2020
Keno
reviewed
Jan 3, 2020
| Value *ptr = maybe_decay_tracked(data_pointer(ctx, obj)); | ||
| *ret = typed_load(ctx, ptr, vidx, jt, obj.tbaa, nullptr, false); | ||
| *ret = typed_load(ctx, ptr, vidx, |
There was a problem hiding this comment.
The return cgval gets annotated with the type we pass in. Does widening to Any pessimize later codegen?
There was a problem hiding this comment.
I'd guess not really, since codegen generally uses inferred types when it needs type info. We're also doing the same thing for arrayref on pointer arrays, so it'd better work 😛
This was referenced Jan 3, 2020
KristofferC
pushed a commit
that referenced
this pull request
Jan 8, 2020
KristofferC
pushed a commit
that referenced
this pull request
Apr 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #34208. Uses the same method as the
typed_loadcall forarrayref.fix #34206, fix #34207