Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #34415, remove affinity setting code #34433

Merged
merged 1 commit into from
Jan 20, 2020
Merged

fix #34415, remove affinity setting code #34433

merged 1 commit into from
Jan 20, 2020

Conversation

JeffBezanson
Copy link
Member

@JeffBezanson JeffBezanson commented Jan 18, 2020 •
edited
Loading

This was removed before and added back apparently by mistake.

fix #34415

@JeffBezanson JeffBezanson added the multithreading Base.Threads and related functionality label Jan 18, 2020
@Keno
Copy link
Member

Keno commented Jan 19, 2020

Test please :). This already regressed once.

@Keno Keno added the needs tests Unit tests are required for this change label Jan 19, 2020
@JeffBezanson
Copy link
Member Author

Is it ok to use taskset to test this? (Linux only though I assume?)

@JeffBezanson
fix #34415, remove affinity setting code
364f45d 
This was removed before and added back apparently by mistake.
@KristofferC KristofferC removed the needs tests Unit tests are required for this change label Jan 20, 2020
@KristofferC
Copy link
Member

Seems like it works. Gonna merge this so I can get it into the 1.4 branch and merge that when CI passes.

@KristofferC KristofferC merged commit 5928786 into master Jan 20, 2020
@KristofferC KristofferC deleted the jb/fix34415 branch January 20, 2020 08:34
KristofferC pushed a commit that referenced this pull request Jan 20, 2020
@JeffBezanson @KristofferC
fix #34415, remove affinity setting code (#34433)
139696b 
This was removed before and added back apparently by mistake.

(cherry picked from commit 5928786)
@KristofferC KristofferC mentioned this pull request Jan 20, 2020
Merged
28 tasks
KristofferC pushed a commit that referenced this pull request Apr 11, 2020
@JeffBezanson @KristofferC
fix #34415, remove affinity setting code (#34433)
0b07681 
This was removed before and added back apparently by mistake.
BioTurboNick pushed a commit to BioTurboNick/julia that referenced this pull request Apr 13, 2020
@JeffBezanson @BioTurboNick
fix JuliaLang#34415, remove affinity setting code (JuliaLang#34433)
490d5e6 
This was removed before and added back apparently by mistake.

(cherry picked from commit 5928786)
@mloubout
Copy link

mloubout commented Apr 29, 2020 •
edited
Loading

Doesn't work on 1.3.1
This issue is still happenning

$ numactl --physcpubind=1,2 -- julia -E 'run(`numactl -s`)'
policy: default
preferred node: current
physcpubind: 0 1 2 3 4 5 6 7 
cpubind: 0 
nodebind: 0 
membind: 0 
Process(`numactl -s`, ProcessExited(0))

@Keno
Copy link
Member

Keno commented Apr 29, 2020

Looks like 1.4 was the first version with this fix?

@mloubout
Copy link

It looks fixed in 1.4 indeed thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
multithreading Base.Threads and related functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Julia seems to ignore process affinity settings on Linux
4 participants
@JeffBezanson @Keno @KristofferC @mloubout