Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge pull request #34561 from JuliaLang/sf/bump_openblas_version #34561

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Merge pull request #34561 from JuliaLang/sf/bump_openblas_version #34561

merged 1 commit into from
Jan 30, 2020

Conversation

staticfloat
Copy link
Member

This should fix FreeBSD issues.

@ararslan ararslan changed the title Bump OpenBLAS BB tarball version and update checksums [release-1.4] Bump OpenBLAS BB tarball version and update checksums Jan 29, 2020
@staticfloat staticfloat mentioned this pull request Jan 29, 2020
Merged
@staticfloat
Copy link
Member Author

@KristofferC I've opened this PR directly against release-1.4, is that the correct way to target 1.4 without going through master first? Also, the windows failures look like they're due to us needing to backport #34506. I'll open a PR to do that first.

@KristofferC
Copy link
Member

KristofferC commented Jan 29, 2020 •
edited
Loading

I've opened this PR directly against release-1.4, is that the correct way to target 1.4 without going through master first?

I would prefer if everything went through the backports branch backports-release-1.4 (because that is what we run PkgEval on before merging it into the release branch). You could push this directly to the backport branch or change the merge branch to it.

@staticfloat staticfloat changed the base branch from release-1.4 to backports-release-1.4 January 29, 2020 19:52
@staticfloat staticfloat mentioned this pull request Jan 29, 2020
Merged
@staticfloat staticfloat changed the title [release-1.4] Bump OpenBLAS BB tarball version and update checksums Merge pull request #34561 from JuliaLang/sf/bump_openblas_version Jan 30, 2020
@staticfloat staticfloat merged commit 449d69d into backports-release-1.4 Jan 30, 2020
@staticfloat staticfloat deleted the sf/bump_openblas_version branch January 30, 2020 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@staticfloat @KristofferC