handle masked_gather in late-gc-lowering #34583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
added
GC
vchuravy
commented
Jan 29, 2020
26 tasks
|
Bump, can this be merged? |
vtjnash
force-pushed
the
vc/masked_gather
branch
from
8293044
to
05a743a
Compare
Vectorized loads can come in 3 variants: - scalar - masked - gather All work about the same--if we run into a Loaded pointer, we need to follow back the base pointer and track it. And otherwise they're just normal def/use statements. But we also need to fix up after an LLVM mistake and put a valid value in the pass-through slot. Co-authored-by: Jameson Nash <vtjnash@gmail.com>
Even non LoadInst / StoreInst (esp. vectorized loads and stores) can have this information
vchuravy
force-pushed
the
vc/masked_gather
branch
from
05a743a
to
40d0bc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #34569