Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Update LLVM_asserts location for new JLL package #34787

Closed
wants to merge 3 commits into from
Closed

[WIP] Update LLVM_asserts location for new JLL package #34787

wants to merge 3 commits into from

Conversation

staticfloat
Copy link
Member

Still waiting for some binaries to finish uploading, will re-run CI when ready.

@KristofferC

This comment has been minimized.

Sign in to view
@staticfloat staticfloat reopened this Feb 18, 2020
@staticfloat staticfloat mentioned this pull request Feb 18, 2020
Merged
26 tasks
@staticfloat staticfloat marked this pull request as ready for review February 19, 2020 19:48
@staticfloat
Copy link
Member Author

I also eliminated the BINARYBUILDER_LLVM_ASSERTS flag; it just triggers off of LLVM_ASSERTIONS=1 instead.

@vtjnash
Copy link
Member

vtjnash commented Feb 25, 2020

Looks like many real bugs there

@staticfloat staticfloat deleted the sf/LLVM_asserts_jll branch November 3, 2020 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vchuravy vchuravy vchuravy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@staticfloat @KristofferC @vtjnash @vchuravy