Fix inverse of SVD of complex matrix (#34866) #34872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfourquet
added
bugfix
andreasnoack
approved these changes
Feb 26, 2020
|
It looks like there is a general CI problem. We should restart CI once it's running normally again. |
|
Should we try again? Also, does this still have a chance to go into 1.4.0 since it's only a bug fix? (When is "bug fix freeze"?) |
|
@crstnbr Maybe rebasing this PR would help? CI looks horrible, but unlike in other currently running PRs. EDIT: I should have updated my webpage. Looks much better know, with failures in |
carstenbauer
force-pushed
the
fixinvsvd
branch
from
8975fec to
8f890ed
Compare
|
I've rebased onto master, let's see what CI gives this time. |
|
CI looks good to me. The timed out run seems unrelated. Ready to be merged? |
|
I marked this for backport to 1.4. The slightly broken method was introduced in v1.3. |
KristofferC
pushed a commit
that referenced
this pull request
Mar 23, 2020
Closes #34866 (cherry picked from commit f709331)
27 tasks
ravibitsgoa
pushed a commit
to ravibitsgoa/julia
that referenced
this pull request
Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in JuliaLang/LinearAlgebra.jl#698. I also added a test with a complex matrix so that this won't happen again :)
Closes JuliaLang/LinearAlgebra.jl#698