Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

speed up llvmcall unique name generation #35144

Merged
merged 1 commit into from
Mar 20, 2020
Merged

speed up llvmcall unique name generation #35144

merged 1 commit into from
Mar 20, 2020

Conversation

JeffBezanson
Copy link
Member

@JeffBezanson JeffBezanson commented Mar 17, 2020 •
edited
Loading

This speeds up codegen of functions that use many duplicate llvmcalls, such as in LoopVectorization/SIMDPirates. From issue #35131

For me this takes the time to run the LoopVectorization tests from 5'40" to 5'15" (note this is a somewhat slow machine).

@JeffBezanson JeffBezanson added compiler:codegen Generation of LLVM IR and native code compiler:latency Compiler latency labels Mar 17, 2020
@JeffBezanson JeffBezanson requested a review from vtjnash March 18, 2020 23:55
vtjnash
vtjnash reviewed Mar 19, 2020
View reviewed changes
src/ccall.cpp Outdated Show resolved Hide resolved
vtjnash
vtjnash reviewed Mar 19, 2020
View reviewed changes
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This variable needs to go away (soon), but might as well use the existing name, so that we can grep for it.

@JeffBezanson JeffBezanson merged commit 5d5f799 into master Mar 20, 2020
@JeffBezanson JeffBezanson deleted the jb/llvmcallnames branch March 20, 2020 19:30
KristofferC pushed a commit that referenced this pull request Mar 23, 2020
@JeffBezanson @KristofferC
speed up llvmcall unique name generation (#35144)
1b9d8ac 
(cherry picked from commit 5d5f799)
@KristofferC KristofferC mentioned this pull request Mar 23, 2020
Merged
27 tasks
KristofferC pushed a commit that referenced this pull request Mar 23, 2020
@JeffBezanson @KristofferC
speed up llvmcall unique name generation (#35144)
71fcb9a 
(cherry picked from commit 5d5f799)
oxinabox pushed a commit to oxinabox/julia that referenced this pull request Apr 8, 2020
@JeffBezanson @oxinabox
speed up llvmcall unique name generation (JuliaLang#35144)
2187c65
ravibitsgoa pushed a commit to ravibitsgoa/julia that referenced this pull request Apr 9, 2020
@JeffBezanson @ravibitsgoa
speed up llvmcall unique name generation (JuliaLang#35144)
851340c
KristofferC pushed a commit that referenced this pull request Apr 11, 2020
@JeffBezanson @KristofferC
speed up llvmcall unique name generation (#35144)
8719d84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash left review comments

Assignees
No one assigned
Labels
compiler:codegen Generation of LLVM IR and native code compiler:latency Compiler latency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JeffBezanson @vtjnash @KristofferC