multiplication of sparse triangular matrices #35609 #35610 #35642 #35659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkarrasch
added
domain:linear algebra
|
bump |
|
@dkarrasch , is there a chance that somebody reviews this PR? |
|
It would be great to get this reviewed. I'm afraid I'm not really qualified though. |
dkarrasch
approved these changes
May 20, 2020
There was a problem hiding this comment.
LGTM, very impressive work. It took me quite a while to figure out all the nnz, nonzeros etc for the different views and all that. I think it would be really helpful to explicitly test them with a hand-written sparse matrix/vector à la sparse(I, J, V, 10, 10) or sparsevec(I, V). In case anyone comes back and reviews this code again, having such a small example would help to understand quicker what the expected outcome should be.
|
Shall I add test cases? |
That would be fantastic, yes. |
|
forgetmenot |
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 11, 2020
…g#35610 JuliaLang#35642 (JuliaLang#35659) * multiplication of sparse triangular matrices * removed disambiguity and improved test cases * test cases for `nnz, nzrange, rowvals, nonzeros`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35609
Fixes #35610
Fixes #35642
Multiplying a sparse triangular matrix with a sparse matrix now is possible.
The result type is a triangular sparse matrix or a sparse matrix.
Multiplying a sparse triangular matrix with a sparse vector now yields a sparse vector.