remove unnecessary ::Union{} type asserts

[KristofferC]

Are these here for documentation purposes? Could rename the functions as throw_... something instead then.

[StefanKarpinski]

I think they were there for performance reasons. Renaming to throw_ would be good though.

[KristofferC]

I didn't notice any difference in generated code. Only some instructions that converted the type assert was gone in the PR version (these where in dead code though). So I don't think there is a performance reason anymore at least.

[Keno]

LGTM, though I agree these could be renamed to something indicating that they are error checks, or throw functions respectively.

[KristofferC]

Updated the names.

[Sacha0]

Thanks Kristoffer! :)

[Sacha0]

The package_win32 failure appears unrelated

make[1]: Entering directory '/cygdrive/c/buildbot/worker/package_win32/build/deps'
[ ! -e /cygdrive/c/buildbot/worker/package_win32/build/usr/manifest/llvm-tools ] || make uninstall-llvm-tools
/cygdrive/c/buildbot/worker/package_win32/build/deps/tools/jlchecksum /tmp/srccache/LLVM.v11.0.0+6.i686-w64-mingw32-cxx11.tar.gz
mkdir -p /cygdrive/c/buildbot/worker/package_win32/build/usr
/usr/bin/tar -xmzf /tmp/srccache/LLVM.v11.0.0+6.i686-w64-mingw32-cxx11.tar.gz -C /cygdrive/c/buildbot/worker/package_win32/build/usr
echo 'LLVM.v11.0.0+6.i686-w64-mingw32-cxx11 bb-uninstaller' > /cygdrive/c/buildbot/worker/package_win32/build/usr/manifest/llvm-tools
make[1]: Leaving directory '/cygdrive/c/buildbot/worker/package_win32/build/deps'
 ==> ./julia binary sizes
/cygdrive/c/buildbot/worker/package_win32/build/usr/tools/llvm-size.exe -A `cygpath -w /cygdrive/c/buildbot/worker/package_win32/build/usr/lib/julia/sys.dll` `cygpath -w /cygdrive/c/buildbot/worker/package_win32/build/usr/bin/libjulia.dll` `cygpath -w /cygdrive/c/buildbot/worker/package_win32/build/usr/bin/julia.exe`
C:/buildbot/worker/package_win32/build/usr/tools/llvm-size.exe: error while loading shared libraries: LLVM.dll: cannot open shared object file: No such file or directory
make: *** [Makefile:566: build-stats] Error 127
program finished with exit code 2