Fix introspection macros for getproperty #35895
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-
@code_
introspection macros currently fail on calls togetproperty
with the dot syntax. The reason is that@which
should not answer the same thing depending on whether it's a call togetproperty
with a module or not, i.e. the two following behaviors are expected:This is something I overlooked in #35522. And currently the second case fails:
This PR fixes that. It unfortunately breaks a test that I had intentionally put in #35522. The reasoning was that the two different calls with the dot syntax were ambiguous, so we have to error in the latter case. But actually the two calls are not ambiguous: we simply have to check whether the left-hand side of the dot is a module or not, which cannot be done at macro expansion but can certainly be done runtime.
Anyway, bottom line is:
@which
now differentiates betweenSomeModule.x
andfoo.bar
(wherefoo
is not a module) and now works in both cases (instead of only the first)@less
,@edit
,@functionloc
don't fail anymore on calls togetproperty
with the dot syntax.