fix some 1.5 compatibility issues #35965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- restore some `copyto!` methods that Knet assumed existed - allow `findfirst` to work on InfiniteArrays again - allow constructing a LineNumberNode from a String
KristofferC
pushed a commit
that referenced
this pull request
May 25, 2020
- restore some `copyto!` methods that Knet assumed existed - allow `findfirst` to work on InfiniteArrays again - allow constructing a LineNumberNode from a String (cherry picked from commit 853fe04)
15 tasks
goretkin
reviewed
Aug 7, 2020
| @@ -1762,8 +1774,8 @@ CartesianIndex(1, 1) | |||
| ``` | |||
| """ | |||
| function findnext(testf::Function, A, start) | |||
| i = oftype(first(keys(A)), start) | |||
There was a problem hiding this comment.
Probably prompted by
Periodic: Error During Test at /home/pkgeval/.julia/packages/ApproxFun/IC3js/test/ReadmeTest.jl:75
Got exception outside of a @test
MethodError: no method matching InfiniteArrays.Infinity(::Int64)
Closest candidates are:
InfiniteArrays.Infinity(::T) where T<:Number at boot.jl:715
InfiniteArrays.Infinity() at /home/pkgeval/.julia/packages/InfiniteArrays/aQOI9/src/Infinity.jl:15
InfiniteArrays.Infinity(!Matched::Float16) where T<:Integer at float.jl:71
...
Stacktrace:
[1] convert(::Type{InfiniteArrays.Infinity}, ::Int64) at ./number.jl:7
[2] oftype(::InfiniteArrays.Infinity, ::Int64) at ./essentials.jl:367
[3] findnext(::ApproxFunBase.var"#286#287"{Int64}, ::InfiniteArrays.InfStepRange{Int64,Int64}, ::Int64) at ./array.jl:1766
[4] findfirst(::Function, ::InfiniteArrays.InfStepRange{Int64,Int64}) at ./array.jl:1820
[5] block(::ApproxFunBase.SumSpace{Tuple{CosSpace{PeriodicSegment{Float64},Float64},SinSpace{PeriodicSegment{Float64},Float64}},PeriodicSegment{Float64},Float64}, ::Int64) at /home/pkgeval/.julia/packages/ApproxFunBase/Jv4NR/src/Spaces/SumSpace.jl:35
[6] default_Fun(::ApproxFunBase.DFunction, ::ApproxFunBase.SumSpace{Tuple{CosSpace{PeriodicSegment{Float64},Float64},SinSpace{PeriodicSegment{Float64},Float64}},PeriodicSegment{Float64},Float64}) at /home/pkgeval/.julia/packages/ApproxFunBase/Jv4NR/src/constructors.jl:127
[7] Fun(::Function, ::ApproxFunBase.SumSpace{Tuple{CosSpace{PeriodicSegment{Float64},Float64},SinSpace{PeriodicSegment{Float64},Float64}},PeriodicSegment{Float64},Float64}) at /home/pkgeval/.julia/packages/ApproxFunBase/Jv4NR/src/constructors.jl:177
[8] top-level scope at /home/pkgeval/.julia/packages/ApproxFun/IC3js/test/ReadmeTest.jl:76
[9] top-level scope at /workspace/srcdir/usr/share/julia/stdlib/v1.5/Test/src/Test.jl:1114
[10] top-level scope at /home/pkgeval/.julia/packages/ApproxFun/IC3js/test/ReadmeTest.jl:76
[11] top-level scope at /workspace/srcdir/usr/share/julia/stdlib/v1.5/Test/src/Test.jl:1114
[12] top-level scope at /home/pkgeval/.julia/packages/ApproxFun/IC3js/test/ReadmeTest.jl:5
[13] include(::String) at ./client.jl:457
[14] top-level scope at ./timing.jl:174 [inlined]
[15] top-level scope at /home/pkgeval/.julia/packages/ApproxFun/IC3js/test/runtests.jl:0
[16] include(::String) at ./client.jl:457
[17] top-level scope at none:6
[18] eval(::Module, ::Any) at ./boot.jl:331
[19] exec_options(::Base.JLOptions) at ./client.jl:272
[20] _start() at ./client.jl:506
to permit e.g. findfirst(>(5), 1:InfiniteArrays.Infinity()) to work
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 11, 2020
- restore some `copyto!` methods that Knet assumed existed - allow `findfirst` to work on InfiniteArrays again - allow constructing a LineNumberNode from a String
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
copyto!methods that Knet assumed existedfindfirstto work on InfiniteArrays again