Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

julia_versionnumber #36223

Closed
wants to merge 2 commits into from
Closed

julia_versionnumber #36223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8f69e6
julia_versionnumber
aminya Jun 10, 2020
eaddf72
remove VERSION and nightly comparison test
aminya Jun 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions base/version.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,3 +300,39 @@ function banner(io::IO = stdout)
""")
end
end

"""
julia_versionnumber(v::String)
julia_versionnumber(v::VersionNumber)

returns the Julia version number by following the same specifications as VersionNumber.

`julia_versionnumber` will fetch the latest nightly version number if `"nightly"` or `"latest"` is given as the input.

# Examples
```julia
julia> julia_versionnumber("nightly")
v"1.6.0-DEV"
```

```jldoctest
julia> julia_versionnumber("1.2.3")
v"1.2.3"

julia> julia_versionnumber(v"1.2.3")
v"1.2.3"
```
"""
julia_versionnumber(v::VersionNumber) = v
function julia_versionnumber(v::String)
if in(v, ["nightly", "latest"])
version_path = download(
"https://raw.githubusercontent.com/JuliaLang/julia/master/VERSION",
joinpath(tempdir(), "VERSION.txt"),
)
version_str = replace(Base.read(version_path, String), "\n" => "")
return VersionNumber(version_str)
else
return VersionNumber(v)
end
end
6 changes: 6 additions & 0 deletions test/version.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,3 +227,9 @@ io = IOBuffer()
@test VersionNumber(true, 0x2, Int128(3), (GenericString("rc"), 0x1)) == v"1.2.3-rc.1"
@test VersionNumber(true, 0x2, Int128(3), (GenericString("rc"), 0x1)) == v"1.2.3-rc.1"
@test VersionNumber(true, 0x2, Int128(3), (), (GenericString("sp"), 0x2)) == v"1.2.3+sp.2"

# julia_versionnumber
@test julia_versionnumber("nightly") ==
VersionNumber(replace(Base.read("VERSION", String), "\n" => ""))
@test julia_versionnumber("1.2.3") == v"1.2.3"
@test julia_versionnumber(v"1.2.3") == v"1.2.3"