deleteat! : check bounds for the first passed index #36231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All other indices are bound-checked.
Currently, the behavior looks like:
```julia
julia> deleteat!([1:1000;], [-100])
signal (11): Segmentation fault
[...]
julia> deleteat!(BigInt[0], [0])
free(): invalid next size (normal)
signal (6): Aborted
[...]
julia> deleteat!(BigInt[0], [-100])
ERROR: UndefRefError: access to undefined reference
[...]
julia> deleteat!([0], [0])
Int64[]
julia> deleteat!([0], [2])
1-element Array{Int64,1}:
0
julia> deleteat!([0], [3])
ERROR: InexactError: check_top_bit(UInt64, -1)
[...]
```
With this commit, all these expressions throw a `BoundsError`.
rfourquet
added
arrays
|
Wow, good catch. |
Co-authored-by: Simeon Schaub <simeondavidschaub99@gmail.com>
KristofferC
pushed a commit
that referenced
this pull request
Jun 16, 2020
* deleteat! : check bounds for the first passed index
All other indices are bound-checked.
Currently, the behavior looks like:
```julia
julia> deleteat!([1:1000;], [-100])
signal (11): Segmentation fault
[...]
julia> deleteat!(BigInt[0], [0])
free(): invalid next size (normal)
signal (6): Aborted
[...]
julia> deleteat!(BigInt[0], [-100])
ERROR: UndefRefError: access to undefined reference
[...]
julia> deleteat!([0], [0])
Int64[]
julia> deleteat!([0], [2])
1-element Array{Int64,1}:
0
julia> deleteat!([0], [3])
ERROR: InexactError: check_top_bit(UInt64, -1)
[...]
```
With this commit, all these expressions throw a `BoundsError`.
* Update base/array.jl
Co-authored-by: Simeon Schaub <simeondavidschaub99@gmail.com>
Co-authored-by: Simeon Schaub <simeondavidschaub99@gmail.com>
(cherry picked from commit 6cdfcf9)
26 tasks
simeonschaub
added a commit
to simeonschaub/julia
that referenced
this pull request
Aug 11, 2020
* deleteat! : check bounds for the first passed index
All other indices are bound-checked.
Currently, the behavior looks like:
```julia
julia> deleteat!([1:1000;], [-100])
signal (11): Segmentation fault
[...]
julia> deleteat!(BigInt[0], [0])
free(): invalid next size (normal)
signal (6): Aborted
[...]
julia> deleteat!(BigInt[0], [-100])
ERROR: UndefRefError: access to undefined reference
[...]
julia> deleteat!([0], [0])
Int64[]
julia> deleteat!([0], [2])
1-element Array{Int64,1}:
0
julia> deleteat!([0], [3])
ERROR: InexactError: check_top_bit(UInt64, -1)
[...]
```
With this commit, all these expressions throw a `BoundsError`.
* Update base/array.jl
Co-authored-by: Simeon Schaub <simeondavidschaub99@gmail.com>
Co-authored-by: Simeon Schaub <simeondavidschaub99@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All other indices are bound-checked.
Currently, the behavior looks like:
With this commit, all these expressions throw a
BoundsError.