remove more global state from codegen #36260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
force-pushed
the
jn/codegen-unglobal
branch
from
52a9119
to
b5cff71
Compare
|
Not sure if exactly the same bug as https://build.julialang.org/#/builders/48/builds/527 but I was getting an inconsistent error like that during builds and "solved" it (temporarily worked around it) by adding a '\0' to the end of the numbered function names. It looks like somewhere explicit-length strings are not getting converted correctly to null terminated string where required for native function names. |
vtjnash
force-pushed
the
jn/codegen-unglobal
branch
from
b5cff71
to
cb993f3
Compare
|
Yes, it is that bug, and is caused by the unpredictability of the ordering of running finalizers. It is being fixed here. |
|
I'll plan to merge this tomorrow. Though review would be good (@JeffBezanson @Keno or @maleadt perhaps). |
Keno
approved these changes
Jun 15, 2020
vchuravy
reviewed
Jun 16, 2020
Keno
requested changes
Jun 16, 2020
…unctions We already had prepare_global/prepare_call functions. This simply lets us use that to allocate these on-demand instead of keeping around a global copy of them to template from.
vtjnash
force-pushed
the
jn/codegen-unglobal
branch
from
cb993f3
to
26de664
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annoyed by https://build.julialang.org/#/builders/48/builds/527, I decided to spend some time removing more global state from codegen and wrapping it into our jl_codegen_params_t context.
While we still have some work to do to remove the global use of many Type objects, and to remove the global counter (we'll need to figure out a different mechanism when merging modules to identify unique values), this is another step in that direction.