Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch httpbin tests over to JuliaLang-hosted httpbin mock server #36336

Merged
merged 2 commits into from
Jun 18, 2020
Merged

Switch httpbin tests over to JuliaLang-hosted httpbin mock server #36336

merged 2 commits into from
Jun 18, 2020

Conversation

staticfloat
Copy link
Member

This should fix the recent testing issues we've had with httpbin.

@staticfloat staticfloat added test This change adds or pertains to unit tests backport 1.4 labels Jun 17, 2020
Keno
Keno reviewed Jun 17, 2020
View reviewed changes
Keno
Keno approved these changes Jun 18, 2020
View reviewed changes
Copy link
Member

@Keno Keno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add the API definition in contrib or something, in case we get hit by two badly timed buses and somebody else needs to re-deploy this, but LGTM otherwise.

@staticfloat staticfloat merged commit 96fc2aa into master Jun 18, 2020
@staticfloat staticfloat deleted the sf/httpbin branch June 18, 2020 08:33
KristofferC pushed a commit that referenced this pull request Jun 18, 2020
@staticfloat @KristofferC
Switch httpbin tests over to JuliaLang-hosted httpbin mock server (…
d3bc87f 
…#36336)

(cherry picked from commit 96fc2aa)
@KristofferC KristofferC mentioned this pull request Jun 18, 2020
Merged
26 tasks
simeonschaub pushed a commit to simeonschaub/julia that referenced this pull request Aug 11, 2020
@staticfloat @simeonschaub
Switch httpbin tests over to JuliaLang-hosted httpbin mock server (…
90c8a6f 
…JuliaLang#36336)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keno Keno Keno approved these changes

Assignees
No one assigned
Labels
test This change adds or pertains to unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@staticfloat @Keno @KristofferC