Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few bugs and brings performance improvements; for the full release notes, see https://gmplib.org/gmp6.2.
Removed
deps/patches/gmp-config-ldflags.patch
as it is no longer needed.Adjusted
deps/patches/gmp-exception.patch
(in principle it could go, but then on Windows division by zero of GMP integers would not lead to aDivideError
but instead a genericErrorException
)This is
the same asan improved version of #36309 which was reverted in #36328 as it was failing the pre-merge CI tests on Win32 and Win64. Moreover, there were other issues (see JuliaPackaging/Yggdrasil#1159 and JuliaRegistries/General#16517), so naturally this PR here shouldn't be merged hastily. But I wanted to submit it so that I can see what the failures on Win32 and Win64 are so that hopefully they can be debugged and resolved.UPDATE: I added back a variant of the GMP exception pass to ensure behavior for division by zero of GMP bigints stayed the same on Windows, too. See also JuliaPackaging/Yggdrasil#1188