added documentation for Dates.TimeZone, Dates.UTC #36475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshyatt
added
dates
quinnj
reviewed
Jul 4, 2020
| TimeZone | ||
|
|
||
| Geographic zone generally based on longitude determining what the time is at a certain location. | ||
| Some time zones observe daylight savings (eg EST -> EDT). |
There was a problem hiding this comment.
I think it'd be helpful to add a mention of the TimeZones.jl package here; if people are looking at TimeZone docs, they most likely need the package anyway.
quinnj
reviewed
Jul 7, 2020
|
Perhaps better to squash this at merge? |
|
Oops; I guess I missed that option. I had committed my suggestion and I don't remember seeing the option to squash or not; but I probably just missed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #31202