Respect memory constraints during init. #36479
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure #24617 should have been closed, as
uv_get_total_memory
doesn't change when running with, e.g.,docker run --memory 3G
. Instead, libuv now hasuv_get_contrained_memory
, which we should probably respect when initializing the heap.I think this is the cause for some GPU CI issues, where docker kills the process once we exceed the memory limit (i.e. we don't get a nice OOM error). That happens often, I assume because the GC doesn't know about the actual memory limit.
Like nodejs/node#27508