Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some minor code quality / correctness improvements #36596

Merged
merged 5 commits into from
Jul 13, 2020
Merged

some minor code quality / correctness improvements #36596

merged 5 commits into from
Jul 13, 2020

Commits on Jul 10, 2020

  1. code_llvm: fix line info regression caused by #36358 

    We need to run the PassManager passes before we destroy important metadata.
    @vtjnash
    vtjnash committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    e93d965 View commit details
    Browse the repository at this point in the history

  2. fix some tfuncs for old deprecations removed in a2149f8 

    These functions were changed in #28380, but their tfuncs were not
changed at that time also.
    @vtjnash
    vtjnash committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    3b2b159 View commit details
    Browse the repository at this point in the history

  3. subtype: cut down the cost of save_env/free dramatically

    @vtjnash
    vtjnash committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    772f8a7 View commit details
    Browse the repository at this point in the history

  4. inference: correction to egal tfunc lattice 

    We were accidentally widening Const(false) here to Bool if either
argument was a Slot (such as an Argument). We don't want to do that!
    @vtjnash
    vtjnash committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    3fec075 View commit details
    Browse the repository at this point in the history

  5. attempt some code quality improvements 

    remove unused type parameters from some functions, add some useful ones
to others, and remove the fallback `==` method in Core.Compiler.
    @vtjnash
    vtjnash committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    dcc0696 View commit details
    Browse the repository at this point in the history