Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine method overwrite warning #36609

Merged
merged 1 commit into from
Jul 10, 2020
Merged

refine method overwrite warning #36609

merged 1 commit into from
Jul 10, 2020

Conversation

vtjnash
Copy link
Sponsor Member

@vtjnash vtjnash commented Jul 10, 2020

Always show the warning for anonymous functions, but update the verbiage
to give additional information. This warning can still be avoided by
explicitly calling delete_method first.

fixes #32635
fixes #35140
refs #15602

Always show the warning for anonymous functions, but update the verbiage
to give additional information. This warning can still be avoided by
explicitly calling delete_method first.

fixes #32635
fixes #35140
refs #15602
@StefanKarpinski StefanKarpinski merged commit 3af7ec8 into master Jul 10, 2020
@StefanKarpinski StefanKarpinski deleted the jn/overwrite-warn branch July 10, 2020 22:26
simeonschaub pushed a commit to simeonschaub/julia that referenced this pull request Aug 11, 2020
Always show the warning for anonymous functions, but update the verbiage
to give additional information. This warning can still be avoided by
explicitly calling delete_method first.

fixes JuliaLang#32635
fixes JuliaLang#35140
refs JuliaLang#15602
@timholy
Copy link
Sponsor Member

timholy commented Sep 7, 2020

This is causing an annoying warning with Revise...EDIT nvm, LoweredCodeUtils was doing a sneaky pre-evaluation. Thanks for helping me find that bug!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants